RFR: 8225644: C1 dumps incorrect class name in ClassCastException message

Vladimir Ivanov vladimir.x.ivanov at oracle.com
Tue Jun 25 17:56:16 UTC 2019


> Or we could add another test case not to change the existing one:
> http://hg.openjdk.java.net/jdk/submit/rev/ba939c7fbedd
> 
> Full branch log:
> http://hg.openjdk.java.net/jdk/submit/log?rev=branch(%22JDK-8225644%22)
> 
> Vladimir, does this look good to you?

Yes, looks good. I'm in favor of a dedicated test rather than 
introducing new C1-specific configuration into existing one from langtools.

Best regards,
Vladimir Ivanov

> On Wed, 19 Jun 2019 at 08:57, Jie Fu <fujie at loongson.cn> wrote:
>>
>> Hi Joe,
>>
>> Are you OK if one more configuration would be added to the failing test[1] ?
>>
>> Thanks a lot.
>> Best regards,
>> Jie
>>
>> [1] http://hg.openjdk.java.net/jdk/submit/rev/9fdceac10323#l2.15
>>
>>
>> On 2019/6/15 上午8:27, Jie Fu wrote:
>>> Thanks Bernard.
>>>
>>> I see all tests on mach5 have passed.
>>> And could I get one more review from the langtools team for the
>>> change[1]?
>>>
>>> Thanks a lot.
>>> Best regards,
>>> Jie
>>>
>>> [1] http://hg.openjdk.java.net/jdk/submit/rev/9fdceac10323
>>>
>>> On 2019/6/15 上午1:53, B. Blaser wrote:
>>>> As shared code is affected, I've pushed it to jdk/submit to make sure
>>>> all is right on every supported systems:
>>>>
>>>> http://hg.openjdk.java.net/jdk/submit/rev/9fdceac10323
>>>>
>>>> I've added a configuration to the failing test which might be kept
>>>> when pushing to jdk/jdk providing that we get a Reviewer approval from
>>>> the langtools team for this?
>>>>
>>>> Thanks,
>>>> Bernard
>>>>
>>>> On Fri, 14 Jun 2019 at 00:55, Jie Fu <fujie at loongson.cn> wrote:
>>>>> Hi Bernard,
>>>>>
>>>>> Thank you for your review.
>>>>> And could you please sponsor it?
>>>>>
>>>>> Thanks a lot.
>>>>> Best regards,
>>>>> Jie
>>>>>
>>>>>
>>>>> On 2019/6/14 上午1:45, B. Blaser wrote:
>>>>>
>>>>>> Seems good to me too.
>>>>>>
>>>>>> Thanks,
>>>>>> Bernard
>>>>>>
>>>>>> On Thu, 13 Jun 2019 at 14:27, Jie Fu <fujie at loongson.cn> wrote:
>>>>>>> Thanks Vladimir Ivanov for your review.
>>>>>>>
>>>>>>> On 2019/6/13 下午5:46, Vladimir Ivanov wrote:
>>>>>>>>> http://cr.openjdk.java.net/~jiefu/8225644/webrev.02/
>>>>>>>> Looks good.
>>>>>>>>
>>>>>>>> Best regards,
>>>>>>>> Vladimir Ivanov
>>>
>>


More information about the hotspot-compiler-dev mailing list