RFR(XS): 8219214: Infinite Loop in CodeSection::dump()

[Schmidt, Lutz]

Update:
Meanwhile, Mach5 tasks reported 0 failed tests. Build Details: 2019-03-04-1542344.lutz.schmidt.source
Regards,
Lutz

On 04.03.19, 17:25, "Schmidt, Lutz" <lutz.schmidt at sap.com> wrote:

    Dear All, 
    
    the "mini-poll" mentioned below showed a clear result:
     yes - 2 votes (delete)
     no  - 0 votes (keep and fix)
    
    I therefore have prepared a new webrev. With that, I removed the methods
    
     CodeBuffer::decode_all()
     CodeBuffer::skip_decode()
     CodeSection::dump()
    
    from the files share/asm/codeBuffer.cpp and share/asm/codeBuffer.hpp. Submit repo results are still pending, but local tests on various platforms run ok. 
    
    Your reviews are appreciated!
    
    Bug:    https://bugs.openjdk.java.net/browse/JDK-8219214
    Webrev: http://cr.openjdk.java.net/~lucy/webrevs/8219214.01/ 
    
    Thanks,
    Lutz
    
    
    On 20.02.19, 14:58, "Schmidt, Lutz" <lutz.schmidt at sap.com> wrote:
    
        Dear All, 
        
        I would like to propose the following change which fixes an infinite loop. 
        
        Bug:    https://bugs.openjdk.java.net/browse/JDK-8219214 
        Webrev: http://cr.openjdk.java.net/~lucy/webrevs/8219214.00/ 
        
        The method affected is called from nowhere inside hotspot code, but could be called via a debugger for diagnostic purposes. BUT: even that doesn’t seem to have happened in the past.
        
        As an alternative, I would suggest to delete the method. Please voice your opinion. I am unbiased to either solution.
        
        Thanks,
        Lutz