RFR(XS): 8219651: compiler/ciReplay/TestServerVM.java is failing on windows

Vladimir Kozlov vladimir.kozlov at oracle.com
Wed Mar 6 18:37:49 UTC 2019


Fix looks good. I would treat it as trivial fix.

Thanks,
Vladimir

On 3/6/19 8:01 AM, Lindenmaier, Goetz wrote:
> Thanks for reviewing!
> 
> ... Oh, 0->9, but in the change it is correct...luckily.
> 
> Best regards,
>    Goetz.
> 
>> -----Original Message-----
>> From: Tobias Hartmann <tobias.hartmann at oracle.com>
>> Sent: Mittwoch, 6. März 2019 16:59
>> To: Lindenmaier, Goetz <goetz.lindenmaier at sap.com>; 'hotspot-compiler-
>> dev at openjdk.java.net' <hotspot-compiler-dev at openjdk.java.net>
>> Subject: Re: RFR(XS): 8210651: compiler/ciReplay/TestServerVM.java is failing
>> on windows
>>
>> Hi Goetz,
>>
>> this looks good to me.
>>
>> (the bug ID in the subject of this email is wrong).
>>
>> Best regards,
>> Tobias
>>
>> On 06.03.19 16:16, Lindenmaier, Goetz wrote:
>>> Hi,
>>>
>>>
>>>
>>> The test is failing in our environment as we pass -Dhttp.nonProxyHosts with a
>> list
>>>
>>> of | separated hosts to the tests. This is needed to make other tests pass.
>>>
>>> The arguments are passed to a shell, where the '|' is interpreted as a pipe.
>>>
>>> Escaping the | as for other symbols helps.
>>>
>>> http://cr.openjdk.java.net/~goetz/wr19/8219651-ciReplay_win/
>>>
>>>
>>>
>>> Best regards,
>>>
>>>    Goetz.
>>>
>>>
>>>


More information about the hotspot-compiler-dev mailing list