RFR (urgent, trivial): 8220515: Revert removal of for_each_lock_value removal

Tobias Hartmann tobias.hartmann at oracle.com
Tue Mar 12 15:09:34 UTC 2019


Hi Claes,

reviewed.

Best regards,
Tobias

On 12.03.19 16:03, Claes Redestad wrote:
> Hi,
> 
> revert the removal of the for_each_lock_value macro part of JDK-8220501,
> as this breaks debug builds.
> 
> Bug: https://bugs.openjdk.java.net/browse/JDK-8220515
> Patch:
> 
> --- a/src/hotspot/share/c1/c1_ValueStack.hpp    Tue Mar 12 15:26:45 2019 +0100
> +++ b/src/hotspot/share/c1/c1_ValueStack.hpp    Tue Mar 12 15:56:59 2019 +0100
> @@ -261,6 +261,14 @@
>         index += value->type()->size())
> 
> 
> +#define for_each_lock_value(state, index, value)                        \
> +  int temp_var = state->locks_size();                        \
> +  for (index = 0;                        \
> +       index < temp_var && (value = state->lock_at(index), true);                        \
> +       index++)                        \
> +    if (value != NULL)
> +
> +
>  // Macro definition for simple iteration of all state values of a ValueStack
>  // Because the code cannot be executed in a single loop, the code must be passed
>  // as a macro parameter.


More information about the hotspot-compiler-dev mailing list