RFR: 8211100: hotspot C1 issue with comparing long numbers on x86 32-bit

Dmitry Cherepanov dcherepanov at azul.com
Tue Mar 19 10:04:16 UTC 2019


Updated webrev with the comment:
http://cr.openjdk.java.net/~dcherepanov/8211100/webrev.05/

Thanks,

Dmitry

> On Mar 18, 2019, at 6:53 PM, Andrew Haley <aph at redhat.com> wrote:
> 
> On 3/13/19 12:43 PM, Dmitry Cherepanov wrote:
>> Updated version of original fix (with ifdef X86 added):
>> http://cr.openjdk.java.net/~dcherepanov/8211100/webrev.04/
>> 
>> Is it okay to push it?
> 
> Surely you cannot contemplate pushing this patch with no explanatory comment.
> 
> "BEWARE! On 32-bit x86 cmp clobbers its left argument so we need a temp copy."
> 
> -- 
> Andrew Haley
> Java Platform Lead Engineer
> Red Hat UK Ltd. <https://www.redhat.com>
> EAC8 43EB D3EF DB98 CC77 2FAD A5CD 6035 332F A671



More information about the hotspot-compiler-dev mailing list