[aarch64-port-dev ] RFR(S): 8216989 - CardTableBarrierSetAssembler::gen_write_ref_array_post_barrier() does not check for zero length on AARCH64

[Andrew Dinn]

On 25/03/2019 16:53, Dmitrij Pochepko wrote:
> Thank you for review.
> pushed to jdk/jdk (had to resolve 1 hunk, because of
> http://hg.openjdk.java.net/jdk/jdk/rev/f4f0dce5d0bb).

Thank you!

> And I'm going to propose this patch for backporting into 11u and 12u
> (Final jdk/jdk patch doesn't apply cleanly for both. Separate webrevs
> and testing will be provided later).
This conversation really needs to happen on the updates list so please
raise it there. However, since we are already talking about it:

Backporting to 11u sounds to me like a worthwhile precaution.

I'm not sure it is worth worrying about 12u. The bug does not appear to
have crashed anything yet (at least not as far as we know :-) and 12u
offers a very limited window for a problem to manifest.

I think it is more important to backport it to the jdk8u aarch64 tree
(which will probably be around for <mumble, mumble> ... some time).

However, let's defer any decision on that to those managing the updates
projects.

regards,


Andrew Dinn
-----------
Senior Principal Software Engineer
Red Hat UK Ltd
Registered in England and Wales under Company Registration No. 03798903
Directors: Michael Cunningham, Michael ("Mike") O'Neill, Eric Shander