RFR: 8219654: AARCH64: Arrays:equals intrinsic documentation and maintenance improvement

Dmitrij Pochepko dmitrij.pochepko at bell-sw.com
Wed Mar 27 13:33:17 UTC 2019


Hi all,

please review patch for 8219654: AARCH64: Arrays:equals intrinsic 
documentation and maintenance improvement

webrev: http://cr.openjdk.java.net/~dpochepk/8219654/webrev.01/

Changes:
- added documentation and variable renaming
- added stub prerequisites checks for debug build to guard against 
incorrect stub usage
- removed unused code block (EARLY_OUT)
- changed loop threshold constant calculation for stub code. It could be 
incorrect in several cases when non-default SoftwarePrefetchHintDistance 
value is specified
- added test to cover all code branches

Testing:

- jtreg tests: hotspot/compiler, hotspot/runtime, hotspot/gc, jdk tier1-3
- jck

no regressions found

CR: https://bugs.openjdk.java.net/browse/JDK-8219654

I'd like to thank Pengfei Li for help with prereview.

I have only one more documentation patch left to be sent (hasNegatives 
intrinsic) and would like to remind that unreviewed patch queue is 
already quite large:

https://mail.openjdk.java.net/pipermail/aarch64-port-dev/2019-January/006795.html
https://mail.openjdk.java.net/pipermail/aarch64-port-dev/2019-February/006940.html
https://mail.openjdk.java.net/pipermail/aarch64-port-dev/2019-February/006956.html
https://mail.openjdk.java.net/pipermail/aarch64-port-dev/2019-March/007028.html
https://mail.openjdk.java.net/pipermail/aarch64-port-dev/2019-March/007036.html

Thanks,
Dmitrij
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.openjdk.java.net/pipermail/hotspot-compiler-dev/attachments/20190327/5f41e959/attachment.html>


More information about the hotspot-compiler-dev mailing list