[13] RFR: 8202414: Unsafe write after primitive array creation may result in array length change

Vladimir Kozlov vladimir.kozlov at oracle.com
Wed Mar 27 16:44:39 UTC 2019


Looks good.

Thanks,
Vladimir

On 3/27/19 6:44 AM, Rahul Raghavan wrote:
> Hi,
> 
> Thank you Vladimir.
> 
> Yes, tried following fix.
> (needed to add checks to avoid SIGFPE crash).
> 
> +  int size_in_bytes = st->memory_size();
> +  if ((size_in_bytes != 0) && (get_store_offset(st, phase) % size_in_bytes) != 0) {
> +    return FAIL;
> +  }
> 
> 
> <webrev.02> - http://cr.openjdk.java.net/~rraghavan/8202414/webrev.02/
> 
> Confirmed no issues with testing for this revised fix.
> 
> Thanks,
> Rahul
> 
> On 26/03/19 1:03 AM, Vladimir Kozlov wrote:
>>
>> Suggestion:
>>
>> if ((get_store_offset(st, phase) % st->memory_size()) != 0) {
>>
>> Vladimir
>>
>>


More information about the hotspot-compiler-dev mailing list