RFR: JDK-8221341 - Update Graal

[Doug Simon]

> On 28 Mar 2019, at 19:33, jesper.wilhelmsson at oracle.com wrote:
> 
> Hi Vladimir,
> 
> Thanks for reviewing!
> 
>> On 28 Mar 2019, at 18:48, Vladimir Kozlov <vladimir.kozlov at oracle.com <mailto:vladimir.kozlov at oracle.com>> wrote:
>> 
>> On 3/28/19 12:37 AM, jesper.wilhelmsson at oracle.com <mailto:jesper.wilhelmsson at oracle.com> wrote:
>>> Hi,
>>> Please review the patch to integrate the latest Graal changes into OpenJDK.
>>> Graal tip to integrate: 7970bd76ff60600ab5a2fc96cd24ddd7ed017cf8
>>> JBS duplicates fixed by this integration:
>>> https://bugs.openjdk.java.net/browse/JDK-8220643 <https://bugs.openjdk.java.net/browse/JDK-8220643>
>>> https://bugs.openjdk.java.net/browse/JDK-8220810
>>> JBS duplicates deferred to the next integration:
>>> https://bugs.openjdk.java.net/browse/JDK-8214947
>> 
>> We should investigate why this bug is still referenced in RFR. We already discussed it:
>> https://mail.openjdk.java.net/pipermail/hotspot-compiler-dev/2019-March/033130.html <https://mail.openjdk.java.net/pipermail/hotspot-compiler-dev/2019-March/033130.html>
> 
> Oops, sorry, missed that. I have removed the link from the next update issue so it won't show up again.
> 
>>> Bug: https://bugs.openjdk.java.net/browse/JDK-8221341 <https://bugs.openjdk.java.net/browse/JDK-8221341>
>>> Webrev: http://cr.openjdk.java.net/~jwilhelm/8221341/webrev.00/ <http://cr.openjdk.java.net/~jwilhelm/8221341/webrev.00/>
>> 
>> We also discussed indentation change in make/test/JtregGraalUnit.gmk
>> Why the change showed up again?
> 
> My understanding was that this was caused by a bug in the mx script. As long as that bug is there this will keep happening. I will try to remember to revert this going forward, but it is something that I will need to do manually every time. Someone should fix the mx script. I don't know who owns that though.

Anyone who can code Python and submit a pull request ;-) I believe these are the relevant lines:

https://github.com/oracle/graal/blob/master/compiler/mx.compiler/mx_updategraalinopenjdk.py#L297-L308

-Doug

> 
>> 
>> Otherwise changes looks good.
>> 
>> Doug, it is good to have only one Graal class to access Unsafe class - GraalUnsafeAccess.java.
>> But we should not use sun.misc.Unsafe in JDK 13 - we should have version for JDK9+ which use jdk.internal.misc.Unsafe. It is for an other update.
>> 
>> Thanks,
>> Vladimir
>> 
>>> Thanks,
>>> /Jesper
> 

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.openjdk.java.net/pipermail/hotspot-compiler-dev/attachments/20190328/4729fee5/attachment.html>