RFR(XS): 8221482: Initialize VMRegImpl::regName[] earlier to prevent assert during PrintStubCode

David Holmes david.holmes at oracle.com
Fri Mar 29 03:59:40 UTC 2019


Hi Lutz,

cc'd the compiler team

On 28/03/2019 9:14 pm, Schmidt, Lutz wrote:
> Dear Community,
> 
> may I please request reviews for this tiny change. The purpose is to initialize the regName[] array earlier during VM init.

I can see that will fix the assertion for you, but then begs the 
question as to whether VMRegImpl::set_regName itself has any 
initialization dependencies. The answer to that is not obvious to me. I 
_think_ the Register setup only depends on C++ static initialization.

Hopefully someone from compiler team can confirm this change is in fact 
safe.

Thanks,
David

> Bug:    https://bugs.openjdk.java.net/browse/JDK-8221482
> Webrev: http://cr.openjdk.java.net/~lucy/webrevs/8221482.01/
> 
> Submit-repo tests pending...
> 
> Thanks,
> Lutz
> 
> 


More information about the hotspot-compiler-dev mailing list