RFR: JDK-8222665 - Update Graal

Vladimir Kozlov vladimir.kozlov at oracle.com
Mon May 6 18:11:38 UTC 2019


It seems webrev is wrong. Jesper, is it possible you sent old webrev?

I looked on patch (from submitted test job) and it seems correct. For example, from next changes [1] it correctly 
updated only Copyright year in JDK (in JDK it was old 2018).
But webrev shows reversed changes [2].

The patch does not have IsGraalPredicate.java changes. But webrev has it with reversed changes again [3].

The same for GraalServices.java file changes. No changes in patch but reverse changes in webrev.

Thanks,
Vladimir

[1] https://github.com/oracle/graal/commit/4fa819e120212393122b55e2c95e9de7c6101ccf#diff-3f2f58ebefeb6c5489c4d264ec8ae502

[2] 
http://cr.openjdk.java.net/~jwilhelm/8222665/webrev.00/src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot/src/org/graalvm/compiler/hotspot/meta/DefaultHotSpotLoweringProvider.java.udiff.html

[3] 
http://cr.openjdk.java.net/~jwilhelm/8222665/webrev.00/src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot/src/org/graalvm/compiler/hotspot/IsGraalPredicate.java.udiff.html

On 5/6/19 7:18 AM, jesper.wilhelmsson at oracle.com wrote:
> Hi,
> 
> Please review the patch to integrate recent Graal changes into OpenJDK.
> Graal tip to integrate: 88c3adb11b1bc10f6443435685b65227e7584b43 >
> Bug: https://bugs.openjdk.java.net/browse/JDK-8222665
> Webrev: http://cr.openjdk.java.net/~jwilhelm/8222665/webrev.00/
> 
> This integration did overwrite changes already in place in OpenJDK. The diff has been attached to the umbrella bug.
> 
> Thanks,
> /Jesper
> 


More information about the hotspot-compiler-dev mailing list