[13] RFR(T) 8223539: compiler/graalunit/HotspotTest.java hotspot.test.CheckGraalIntrinsics AssertionError: found plugins for intrinsics

[Vladimir Ivanov]

Looks good.

Best regards,
Vladimir Ivanov

On 08/05/2019 16:18, Vladimir Kozlov wrote:
> https://bugs.openjdk.java.net/browse/JDK-8223539
> 
> 8222074 added new Math intrinsics abs(F), abs(I), abs(J).
> Usually new intrinsics should be listed in CheckGraalIntrinsics.java 
> Graal's unit test until they are implemented in Graal. And it was done 
> in 8222074 changes [1].
> 
> But Graal has own intrinsics - plugins. And there already plugins for 
> Math.abs(F) and Math.abs(D) [2]. That is why the test failed.
> 
> The fix is trivial - remove line with Math.abs(F) from 
> CheckGraalIntrinsics.java:
> 
> --- 
> a/src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot.test/src/org/graalvm/compiler/hotspot/test/CheckGraalIntrinsics.java 
> 
> +++ 
> b/src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot.test/src/org/graalvm/compiler/hotspot/test/CheckGraalIntrinsics.java 
> 
> @@ -399,5 +399,4 @@
>           if (isJDK13OrHigher()) {
>               add(toBeInvestigated,
> -                            "java/lang/Math.abs(F)F",
>                               "java/lang/Math.abs(I)I",
>                               "java/lang/Math.abs(J)J",
> 
> Thanks,
> Vladimir
> 
> [1] http://hg.openjdk.java.net/jdk/jdk/rev/1851a532ddfe#l24.1
> [2] 
> https://github.com/oracle/graal/blob/master/compiler/src/org.graalvm.compiler.replacements/src/org/graalvm/compiler/replacements/StandardGraphBuilderPlugins.java#L693 
>