RFR/RFC (XS) 8223911: Disable bad node budget verification until the fix

[Vladimir Kozlov]

I agree.

Thanks
Vladimir

> On May 14, 2019, at 11:14 AM, Aleksey Shipilev <shade at redhat.com> wrote:
> 
> Bug:
>  https://bugs.openjdk.java.net/browse/JDK-8223911
> 
> There is a bug that Patric is handling now. However, fastdebug is broken for more than a week, and
> there is no sight of the fix yet. Having this false negative failure is detrimental for testing,
> especially given impending fork to 13. Backing out the change seems too harsh. Let's just disable
> the assert?
> 
> Fix:
> 
> diff -r 809cbe8565a1 -r ee3c58aebd44 src/hotspot/share/opto/loopnode.hpp
> --- a/src/hotspot/share/opto/loopnode.hpp       Tue May 14 20:05:43 2019 +0200
> +++ b/src/hotspot/share/opto/loopnode.hpp       Tue May 14 20:06:51 2019 +0200
> @@ -1384,7 +1384,8 @@
>     uint required = _nodes_required;
>     require_nodes_final();
>     uint delta = C->live_nodes() - live_at_begin;
> -    assert(delta <= 2 * required, "Bad node estimate (actual: %d, request: %d)",
> +    // Assert is disabled, see JDK-8223911 and related issues.
> +    assert(true || delta <= 2 * required, "Bad node estimate (actual: %d, request: %d)",
>            delta, required);
>   }
> 
> Testing: Linux x86_64 fastdebug, regression test from JDK-8223502 (I could have added it, but then
> this fix would not be as trivial and would require passing jdk-submit), our larger workloads that
> used to break
> 
> -- 
> Thanks,
> -Aleksey
> 
>