RFR: JDK-8223346 - Update Graal

Vladimir Kozlov vladimir.kozlov at oracle.com
Thu May 16 20:09:31 UTC 2019


Looks good.

Thanks
Vladimir

> On May 16, 2019, at 1:08 PM, jesper.wilhelmsson at oracle.com wrote:
> 
> New webrev with overwritten and the extra Graal change applied:
> 
> http://cr.openjdk.java.net/~jwilhelm/8223346/webrev.01/
> 
> /Jesper
> 
> 
>> On 14 May 2019, at 23:40, jesper.wilhelmsson at oracle.com wrote:
>> 
>> Dean,
>> 
>> Please attach the diff you want me to add to the bug.
>> JDK-8223441 is in there.
>> 
>> Thanks,
>> /Jesper
>> 
>>> On 14 May 2019, at 23:03, dean.long at oracle.com wrote:
>>> 
>>> I suggest doing the tiers 1-4 testing separate from the tier5+ testing, to reduce noise.
>>> 
>>> There is a fix for CheckGraalIntrinsics coming to upstream Graal.  When Jesper merges the overwritten changes, he could include that fix as well, so that compiler/graalunit/HotspotTest.java passes.
>>> 
>>> The HeapMonitorStatArrayCorrectnessTest failure should have been fixed by JDK-8223441, unless Jesper's test repo is out of date.
>>> 
>>> dl
>>> 
>>>> On 5/14/19 12:32 PM, Vladimir Kozlov wrote:
>>>> Changes seems fine but I am not comfortable about tests results. There are a lot of timeouts again but there are many graalunit tests failures. 
>>>> 
>>>> This time you have to apply overwritten diffs after merge (if we decide to push it) - these changes are not in Graal master repo yet. 
>>>> 
>>>> Thanks, 
>>>> Vladimir 
>>>> 
>>>>> On 5/13/19 5:19 PM, jesper.wilhelmsson at oracle.com wrote: 
>>>>> Hi, 
>>>>> 
>>>>> Please review the patch to integrate recent Graal changes into OpenJDK. 
>>>>> Graal tip to integrate: 6a18d9ddacd8eecb0ae4877f687e171889939c0d 
>>>>> 
>>>>> Bug: https://bugs.openjdk.java.net/browse/JDK-8223346 
>>>>> Webrev: http://cr.openjdk.java.net/~jwilhelm/8223346/webrev.00/ 
>>>>> 
>>>>> This integration did overwrite changes already in place in OpenJDK. The diff has been attached to the umbrella bug. 
>>>>> 
>>>>> Thanks, 
>>>>> /Jesper 
>>>>> 
>>> 
>> 
> 
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.openjdk.java.net/pipermail/hotspot-compiler-dev/attachments/20190516/5e546f3a/attachment-0001.html>


More information about the hotspot-compiler-dev mailing list