RFR:8222302:[TESTBUG]test/hotspot/jtreg/compiler/intrinsics/sha/cli/TestUseSHAOptionOnUnsupportedCPU.java fails on any other CPU

Jie Fu fujie at loongson.cn
Thu May 16 23:17:37 UTC 2019


Hi Vladimir,

Thank you for your review.

Do you think the change is simple enough?
And could you please sponsor it?

Thanks a lot.
Best regards,
Jie

On 2019年05月17日 01:48, Vladimir Kozlov wrote:
> Looks good to me.
>
> Thanks,
> Vladimir
>
> On 5/16/19 4:15 AM, Jie Fu wrote:
>> Ping.
>>
>> Could someone help to review this change?
>> I would greatly appreciate if this test case could be used for our 
>> mips-port jdk.
>>
>> Thanks a lot.
>> Best regards,
>> Jie
>>
>> On 2019/4/11 上午9:51, Jie Fu wrote:
>>> Hi all,
>>>
>>> JBS:    https://bugs.openjdk.java.net/browse/JDK-8222302
>>> Webrev: http://cr.openjdk.java.net/~jiefu/8222302/webrev.00/
>>>
>>> TestUseSHAOptionOnUnsupportedCPU.java fails on any other CPU (not 
>>> AArch64, PPC, S390x, SPARC or X86).
>>> It is designed to test "UseSHASpecificTestCaseForUnsupportedCPU"[1] 
>>> and "GenericTestCaseForOtherCPU"[2] on any other CPU[3].
>>> But when they run on any other CPU (e.g., mips), an exception[4] is 
>>> always thrown, which causes the failure.
>>> So there seems to be a logical bug in it.
>>>
>>> The change has been tested on mips and x86.
>>> Could you please review it?
>>> Thanks a lot.
>>>
>>> Best regards,
>>> Jie
>>>
>>> [1] 
>>> http://hg.openjdk.java.net/jdk/jdk/file/bf07e140c49c/test/hotspot/jtreg/compiler/intrinsics/sha/cli/TestUseSHAOptionOnUnsupportedCPU.java#l56 
>>>
>>> [2] 
>>> http://hg.openjdk.java.net/jdk/jdk/file/bf07e140c49c/test/hotspot/jtreg/compiler/intrinsics/sha/cli/TestUseSHAOptionOnUnsupportedCPU.java#l58 
>>>
>>> [3] 
>>> http://hg.openjdk.java.net/jdk/jdk/file/bf07e140c49c/test/hotspot/jtreg/compiler/intrinsics/sha/cli/testcases/GenericTestCaseForOtherCPU.java#l34 
>>>
>>> [4] 
>>> http://hg.openjdk.java.net/jdk/jdk/file/bf07e140c49c/test/hotspot/jtreg/compiler/intrinsics/sha/cli/SHAOptionsBase.java#l92 
>>>
>>>
>>>
>>




More information about the hotspot-compiler-dev mailing list