RFR:8222302:[TESTBUG]test/hotspot/jtreg/compiler/intrinsics/sha/cli/TestUseSHAOptionOnUnsupportedCPU.java fails on any other CPU

[Vladimir Kozlov]

Yes. I tested it and pushed:
http://hg.openjdk.java.net/jdk/jdk/rev/24c0eeb3ebe7

Regards,
Vladimir

On 5/17/19 8:51 PM, Jie Fu wrote:
> Thanks dl for your review.
> 
> Vladimir, is it OK to be pushed?
> 
> Thanks a lot.
> Best regards,
> Jie
> 
> On 2019/5/18 上午4:59, dean.long at oracle.com wrote:
>> Seems fine to me.  However, these tests seem overly complicated.  I don't think we test other flags quite so thoroughly!
>>
>> dl
>>
>> On 5/17/19 8:03 AM, Jie Fu wrote:
>>> Hi all,
>>>
>>> May I have a second review for this change?
>>> We need this test case for our misp port.
>>>
>>> Thanks in advance.
>>> Best regards,
>>> Jie
>>>
>>>
>>> On 2019年05月17日 07:33, Vladimir Kozlov wrote:
>>>> I think you need second review to make sure it is right change. Especially who works on other platforms.
>>>>
>>>> Thanks,
>>>> Vladimir
>>>>
>>>> On 5/16/19 4:17 PM, Jie Fu wrote:
>>>>> Hi Vladimir,
>>>>>
>>>>> Thank you for your review.
>>>>>
>>>>> Do you think the change is simple enough?
>>>>> And could you please sponsor it?
>>>>>
>>>>> Thanks a lot.
>>>>> Best regards,
>>>>> Jie
>>>>>
>>>>> On 2019年05月17日 01:48, Vladimir Kozlov wrote:
>>>>>> Looks good to me.
>>>>>>
>>>>>> Thanks,
>>>>>> Vladimir
>>>>>>
>>>>>> On 5/16/19 4:15 AM, Jie Fu wrote:
>>>>>>> Ping.
>>>>>>>
>>>>>>> Could someone help to review this change?
>>>>>>> I would greatly appreciate if this test case could be used for our mips-port jdk.
>>>>>>>
>>>>>>> Thanks a lot.
>>>>>>> Best regards,
>>>>>>> Jie
>>>>>>>
>>>>>>> On 2019/4/11 上午9:51, Jie Fu wrote:
>>>>>>>> Hi all,
>>>>>>>>
>>>>>>>> JBS: https://bugs.openjdk.java.net/browse/JDK-8222302
>>>>>>>> Webrev: http://cr.openjdk.java.net/~jiefu/8222302/webrev.00/
>>>>>>>>
>>>>>>>> TestUseSHAOptionOnUnsupportedCPU.java fails on any other CPU (not AArch64, PPC, S390x, SPARC or X86).
>>>>>>>> It is designed to test "UseSHASpecificTestCaseForUnsupportedCPU"[1] and "GenericTestCaseForOtherCPU"[2] on any 
>>>>>>>> other CPU[3].
>>>>>>>> But when they run on any other CPU (e.g., mips), an exception[4] is always thrown, which causes the failure.
>>>>>>>> So there seems to be a logical bug in it.
>>>>>>>>
>>>>>>>> The change has been tested on mips and x86.
>>>>>>>> Could you please review it?
>>>>>>>> Thanks a lot.
>>>>>>>>
>>>>>>>> Best regards,
>>>>>>>> Jie
>>>>>>>>
>>>>>>>> [1] 
>>>>>>>> http://hg.openjdk.java.net/jdk/jdk/file/bf07e140c49c/test/hotspot/jtreg/compiler/intrinsics/sha/cli/TestUseSHAOptionOnUnsupportedCPU.java#l56 
>>>>>>>>
>>>>>>>> [2] 
>>>>>>>> http://hg.openjdk.java.net/jdk/jdk/file/bf07e140c49c/test/hotspot/jtreg/compiler/intrinsics/sha/cli/TestUseSHAOptionOnUnsupportedCPU.java#l58 
>>>>>>>>
>>>>>>>> [3] 
>>>>>>>> http://hg.openjdk.java.net/jdk/jdk/file/bf07e140c49c/test/hotspot/jtreg/compiler/intrinsics/sha/cli/testcases/GenericTestCaseForOtherCPU.java#l34 
>>>>>>>>
>>>>>>>> [4] 
>>>>>>>> http://hg.openjdk.java.net/jdk/jdk/file/bf07e140c49c/test/hotspot/jtreg/compiler/intrinsics/sha/cli/SHAOptionsBase.java#l92 
>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>>
>>>>>
>>>>>
>>>
>>>
>>
>