RFR(trival): 8224723: [TESTBUG] compiler/arraycopy/TestArrayCopyWithBadOffset.java failed

[Tobias Hartmann]

Hi Wang,

looks good, but the IgnoreUnrecognizedVMOptions should come first.

I've changed that and sponsored your fix:
http://hg.openjdk.java.net/jdk/jdk/rev/e93621d4db2c

Thanks,
Tobias

On 24.05.19 09:40, Wang Xue wrote:
> Hi Tobias,
> 
> Thanks for your suggestion.
> 
> Update the patch
> ----------------------------------------------------------------
> diff -r d84176dd57b0 test/hotspot/jtreg/compiler/arraycopy/TestArrayCopyWithBadOffset.java
> --- a/test/hotspot/jtreg/compiler/arraycopy/TestArrayCopyWithBadOffset.java Thu May 23 18:47:24 2019
> -0700
> +++ b/test/hotspot/jtreg/compiler/arraycopy/TestArrayCopyWithBadOffset.java Fri May 24 15:31:55 2019
> +0800
> @@ -25,7 +25,7 @@
>   * @test
>   * @bug 8224539
>   * @summary Test arraycopy optimizations with bad src/dst array offsets.
> - * @run main/othervm -Xbatch -XX:+AlwaysIncrementalInline
> + * @run main/othervm -Xbatch -XX:+AlwaysIncrementalInline -XX:+IgnoreUnrecognizedVMOptions
>   * compiler.arraycopy.TestArrayCopyWithBadOffset
>   */
> ----------------------------------------------------------------
> 
> 
> Thanks,
> Wang Xue
> 
> 在 5/24/19 15:16, Tobias Hartmann 写道:
>> Hi,
>>
>> thanks for fixing this! Please just add -XX:+IgnoreUnrecognizedVMOptions to the tests @run statement
>> such that it is also executed with a product build.
>>
>> Thanks,
>> Tobias
>>
>> On 24.05.19 09:12, Wang Xue wrote:
>>> Hi all,
>>>
>>> Bug:  https://bugs.openjdk.java.net/browse/JDK-8224723
>>>
>>> It can be fixed by
>>> ---------------------------------------------------
>>> diff -r ecb7b9a98f0e test/hotspot/jtreg/compiler/arraycopy/TestArrayCopyWithBadOffset.java
>>> --- a/test/hotspot/jtreg/compiler/arraycopy/TestArrayCopyWithBadOffset.java Thu May 23 14:14:13 2019
>>> -0700
>>> +++ b/test/hotspot/jtreg/compiler/arraycopy/TestArrayCopyWithBadOffset.java Fri May 24 14:10:19 2019
>>> +0800
>>> @@ -25,6 +25,7 @@
>>>    * @test
>>>    * @bug 8224539
>>>    * @summary Test arraycopy optimizations with bad src/dst array offsets.
>>> + * @requires (vm.debug == true)
>>>    * @run main/othervm -Xbatch -XX:+AlwaysIncrementalInline
>>>    * compiler.arraycopy.TestArrayCopyWithBadOffset
>>>    */
>>> ---------------------------------------------------
>>>
>>> Could you please review it?
>>>
>>> Thanks,
>>> Wang Xue
>>>
>>>
>