[8u-dev, ppc] RFR for (almost clean) backport of 8185696: PPC64: Improve VSR support to use up to 64 registers

[Doerr, Martin]

Hi,

I think it's fine.

I guess the copyright updates in the other files were part of other changes which have not been backported.
I don't think we have to update copyrights in backport changes other than what comes naturally with the change.

Best regards,
Martin


> -----Original Message-----
> From: hotspot-compiler-dev <hotspot-compiler-dev-
> bounces at openjdk.java.net> On Behalf Of Andrew John Hughes
> Sent: Montag, 27. Mai 2019 18:32
> To: Kazunori Ogata <OGATAK at jp.ibm.com>; hotspot-compiler-
> dev at openjdk.java.net; jdk8u-dev at openjdk.java.net
> Subject: Re: [8u-dev, ppc] RFR for (almost clean) backport of 8185696: PPC64:
> Improve VSR support to use up to 64 registers
> 
> 
> 
> On 27/05/2019 10:06, Kazunori Ogata wrote:
> > Hi,
> >
> > I'm requesting backport of 8185696: PPC64: Improve VSR support to use up
> > to 64 registers to jdk8u-dev.  This patch can be applied almost cleanly,
> > but one chunk failed (other than a copyright year conflict) because the
> > definition of MTVSRWA_OPCODE is missing in
> > src/cpu/ppc/vm/assembler_ppc.hpp.
> >
> > MTVSRWA_OPCODE was added in 8144019: PPC64 C1: Introduce Client
> Compiler
> > [1], which added tiered compilation feature in JDK9.  Since JDK8 does not
> > support tiered compilation, we cannot apply this change set.
> >
> > So I manually applied the failed chunk by skipping the MTVSRWA_OPCODE
> > definition because no code in this changeset and other changesets I'm
> > going to backport uses this opcode.  I'll leave it to the future backport
> > that really needs this opcode.
> >
> > Is this fix acceptable for backport request?  If there is no objection in
> > a few days, I'll go forward to add jdk8u-fix-request tag in the original
> > bug report.  I verified I can build both fastdebug and release version,
> > and no degradation in jtreg.
> >
> >
> > Original bug report:
> > https://bugs.openjdk.java.net/browse/JDK-8185969
> >
> > Webrev:
> > http://cr.openjdk.java.net/~horii/jdk8u_aes_be/8185969/webrev.02/
> >
> > Refs:
> > [1] https://bugs.openjdk.java.net/browse/JDK-8144019
> >
> >
> 
> This mostly looks ok, but why is the copyright header updated to 2019
> for assembler_ppc.hpp, but not register_ppc.hpp and register_ppc.cpp?
> 
> Thanks,
> --
> Andrew :)
> 
> Senior Free Java Software Engineer
> Red Hat, Inc. (http://www.redhat.com)
> 
> PGP Key: ed25519/0xCFDA0F9B35964222 (hkp://keys.gnupg.net)
> Fingerprint = 5132 579D D154 0ED2 3E04  C5A0 CFDA 0F9B 3596 4222
> https://keybase.io/gnu_andrew