[8u-dev, ppc] RFR for (almost clean) backport of 8185696: PPC64: Improve VSR support to use up to 64 registers

Kazunori Ogata OGATAK at jp.ibm.com
Tue May 28 05:22:20 UTC 2019


Hi Andrew and Martin,

Thank you for your comments.

My original intention to change the copyright year was that I did some 
work to apply the original patch to this file.  I now realized I made no 
change in the code that was modified in the original patch.  So I agree 
not updating the copyright year is more natural.

I updated webrev:
http://cr.openjdk.java.net/~horii/jdk8u_aes_be/8185969/webrev.03/


Regards,
Ogata


Andrew John Hughes <gnu.andrew at redhat.com> wrote on 2019/05/28 02:28:28:

> From: Andrew John Hughes <gnu.andrew at redhat.com>
> To: "Doerr, Martin" <martin.doerr at sap.com>, Kazunori Ogata 
> <OGATAK at jp.ibm.com>, "hotspot-compiler-dev at openjdk.java.net" <hotspot-
> compiler-dev at openjdk.java.net>, "jdk8u-dev at openjdk.java.net" <jdk8u-
> dev at openjdk.java.net>
> Date: 2019/05/28 02:28
> Subject: [EXTERNAL] Re: [8u-dev, ppc] RFR for (almost clean) backport of 

> 8185696: PPC64: Improve VSR support to use up to 64 registers
> 
> 
> 
> On 27/05/2019 17:41, Doerr, Martin wrote:
> > Hi,
> > 
> > I think it's fine.
> > 
> > I guess the copyright updates in the other files were part of other 
> changes which have not been backported.
> > I don't think we have to update copyrights in backport changes other 
> than what comes naturally with the change.
> > 
> > Best regards,
> > Martin
> > 
> > 
> 
> The change to the copyright header in assembler_ppc.hpp is an addition
> in this backport. So either that should be dropped or the same should be
> applied to register_ppc.{c,h}pp (the remaining file is already 2019).
> 
> I tend towards dropping it, but we should at least be consistent within
> the same patch.
> 
> Best regards,
> -- 
> Andrew :)
> 
> Senior Free Java Software Engineer
> Red Hat, Inc. (http://www.redhat.com)
> 
> PGP Key: ed25519/0xCFDA0F9B35964222 (hkp://keys.gnupg.net)
> Fingerprint = 5132 579D D154 0ED2 3E04  C5A0 CFDA 0F9B 3596 4222
> https://keybase.io/gnu_andrew
> 
> [attachment "signature.asc" deleted by Kazunori Ogata/Japan/IBM] 



More information about the hotspot-compiler-dev mailing list