RFR(T/S) : 8224945 : googlemock update breaks the build of arm32

David Holmes david.holmes at oracle.com
Wed May 29 07:35:24 UTC 2019


Hi Igor,

This looks good to me. Thanks for fixing so promptly.

David

On 29/05/2019 5:10 pm, Igor Ignatyev wrote:
> http://cr.openjdk.java.net/~iignatyev//8224945/webrev.00/index.html
>> 10 lines changed: 10 ins; 0 del; 0 mod;
> 
> 
> Hi all,
> 
> could you please review this small and trivial patch which undefines R, F1 and F2 macros in unittest.hpp so they won't conflict w/ typenames used in gmock?
> 
> testing: extensive build testing (which found JDK-8224949 -- an unrelated breakage on linux-x86)
> webrev: http://cr.openjdk.java.net/~iignatyev//8224945/webrev.00/index.html
> JBS: https://bugs.openjdk.java.net/browse/JDK-8224945
> 
> Thanks,
> -- Igor
> 


More information about the hotspot-compiler-dev mailing list