RFR(M): 8223363: Bad node estimate assertion failure

Nils Eliasson nils.eliasson at oracle.com
Wed May 29 12:00:23 UTC 2019


Looks good,

// Nils


On 2019-05-29 09:48, Patric Hedlin wrote:
> Updated webrev: http://cr.openjdk.java.net/~phedlin/tr8223363/
>
> Now also including the testcase for/from 8223502.
>
> Best regards,
> Patric
>
> On 28/05/2019 18:50, Aleksey Shipilev wrote:
>> On 5/28/19 6:49 PM, Patric Hedlin wrote:
>>> On 2019-05-28 15:51, Aleksey Shipilev wrote:
>>>> On 5/28/19 3:07 PM, Patric Hedlin wrote:
>>>>> Ooops, sorry. The test-case from 8223502 is here: Webrev:
>>>>> http://cr.openjdk.java.net/~phedlin/tr8223502/
>>>> Yes, so what prevents us from including that test in this 
>>>> changeset? Surely it acts like the
>>>> regression tests for the fix.
>>> Absolutely nothing. The error was only in my webrev generation that 
>>> didn't include both bookmarks.
>>> They will be pushed "as one". (I can generate a new, single, 
>>> complete, webrev in the morning if you
>>> prefer.)
>> Yes, please. I prefer full webrevs to understand what exactly is 
>> being pushed.
>>
>> -Aleksey
>>
>


More information about the hotspot-compiler-dev mailing list