RFR 8233389: Add PrintIdeal to compiler directives

[Vladimir Ivanov]

On 04.11.2019 15:54, Nils Eliasson wrote:
> Hi Jorn,
> 
> One nitpick - in compilerDirectives.hpp: you should surround the line 
> with NOT_PRODUCT(...) similair to how it's done for TraceOptoOutput. You 
> have already made sure that the use is guarded, which is good, but it 
> should show in the list too.

FTR the same applies to IGVPrintLevel:

src/hotspot/share/compiler/compilerDirectives.hpp:
     cflags(IGVPrintLevel,           intx, PrintIdealGraphLevel, 
IGVPrintLevel) \

src/hotspot/share/opto/c2_globals.hpp:
   notproduct(intx, PrintIdealGraphLevel, 0, 


Best regards,
Vladimir Ivanov

> 
> In the future I hope we can make this flag diagnostic.
> 
> Otherwise good.
> 
> Regards,
> 
> Nils
> 
> On 2019-11-01 16:09, Jorn Vernee wrote:
>> Hi,
>>
>> I'd like to add PrintIdeal as a compiler directive in order to enable 
>> PrintIdeal for only a single method when combining it with the 'match' 
>> directive.
>>
>> Please review the following:
>>
>> Bug: https://bugs.openjdk.java.net/browse/JDK-8233389
>> Webrev: http://cr.openjdk.java.net/~jvernee/print_ideal/webrev.00/
>> (Testing = tier1, manual)
>>
>> As a heads-up; I'm not a committer on the jdk project, so if this 
>> sounds like a good idea, I would require a sponsor to push the changes.
>>
>> Thanks,
>> Jorn
>>