RFR: 8233429: Minimal and zero VM build broken after JDK-8227003
Tobias Hartmann
tobias.hartmann at oracle.com
Tue Nov 5 08:43:45 UTC 2019
Looks good to me too. Pushed.
Best regards,
Tobias
On 05.11.19 02:43, Jie Fu wrote:
> Hi Igor,
>
> Thanks for your help and review.
>
> Updated: http://cr.openjdk.java.net/~jiefu/8233429/webrev.02/
> - Added the reviewers in it.
>
> Hope you can sponsor it.
>
> Thanks a lot.
> Best regards,
> Jie
>
> On 2019/11/5 上午1:57, Igor Veresov wrote:
>> This look good to me.
>>
>> igor
>>
>>
>>
>>> On Nov 4, 2019, at 1:33 AM, Jie Fu <fujie at loongson.cn <mailto:fujie at loongson.cn>> wrote:
>>>
>>> Hi Aleksey and Tobias,
>>>
>>> Thanks for your review and valuable comments.
>>>
>>> I'm sorry to mention that Igor is teaching me how to fix the bug off the list these days.
>>>
>>> What do you think of this version?
>>> http://cr.openjdk.java.net/~jiefu/8233429/webrev.01/
>>>
>>> I prefer webrev.01.
>>>
>>> Thanks a lot.
>>> Best regards,
>>> Jie
>>>
>>>
>>> On 2019/11/4 下午4:53, Aleksey Shipilev wrote:
>>>> On 11/2/19 10:29 AM, Jie Fu wrote:
>>>>> Hi all,
>>>>>
>>>>> May I get reviews for this small fix?
>>>>>
>>>>> JBS: https://bugs.openjdk.java.net/browse/JDK-8233429
>>>>> Webrev: http://cr.openjdk.java.net/~jiefu/8233429/webrev.00/
>>>> Looks fine to me.
>>>>
>>>> The alternative is to stub out CompilationModeFlag::*() definitions under TIERED define, but that
>>>> would be more awkward than effectively using the "default" mode for minimal and zero VMs.
>>>>
>>>
>>
More information about the hotspot-compiler-dev
mailing list