RFR: 8233708: VectorSet cleanup
Nils Eliasson
nils.eliasson at oracle.com
Wed Nov 6 15:08:51 UTC 2019
Hi Claes,
Excellent cleanup!
// Nils
On 2019-11-06 15:42, Claes Redestad wrote:
> Hi,
>
> VectorSet needs a cleanup:
>
> - Extravagant use of operator overloading (<<= adds items to the set,
> >>= removes them :eyeroll:)
> - Plenty of unused methods
> - Since VectorSet is the only implementation in the code base, the
> abstract base class Set is unnecessary
> - Various method names in conflict with HotSpot code "standard"
>
> Webrev: http://cr.openjdk.java.net/~redestad/8233708/open.00/
> Bug: https://bugs.openjdk.java.net/browse/JDK-8233708
>
> Testing: tier1-3, built and sanity tested with Shenandoah due changes
> in some Shenandoah C2 support
>
> Thanks!
>
> /Claes
More information about the hotspot-compiler-dev
mailing list