RFR: 8233708: VectorSet cleanup
Tobias Hartmann
tobias.hartmann at oracle.com
Wed Nov 6 15:57:13 UTC 2019
Hi Claes,
very nice. While you're at it, could you add brackets to the for-loops/ifs in vectset.cpp:70,
vectset.hpp:89, 98 and fix the whitespacing? No new webrev required.
Thanks,
Tobias
On 06.11.19 15:42, Claes Redestad wrote:
> Hi,
>
> VectorSet needs a cleanup:
>
> - Extravagant use of operator overloading (<<= adds items to the set,
>>>= removes them :eyeroll:)
> - Plenty of unused methods
> - Since VectorSet is the only implementation in the code base, the
> abstract base class Set is unnecessary
> - Various method names in conflict with HotSpot code "standard"
>
> Webrev: http://cr.openjdk.java.net/~redestad/8233708/open.00/
> Bug: https://bugs.openjdk.java.net/browse/JDK-8233708
>
> Testing: tier1-3, built and sanity tested with Shenandoah due changes
> in some Shenandoah C2 support
>
> Thanks!
>
> /Claes
More information about the hotspot-compiler-dev
mailing list