RFR: 8233885: Test fails with assert(comp != __null) failed: Ensure we have a compiler

Tobias Hartmann tobias.hartmann at oracle.com
Mon Nov 11 07:44:04 UTC 2019


Hi Jie,

what about the high-only-quick-internal mode?

While looking at the fix for 8227003, I spotted a little typo here ("mininum"):
https://hg.openjdk.java.net/jdk/jdk/rev/b95bead30957#l6.8
Maybe you can fix that as well with your patch.

Thanks,
Tobias

On 11.11.19 06:43, Jie Fu wrote:
> Sorry, I missed the test case in webrev.00
> I just added it in webrev.01
> 
> Please review this version: http://cr.openjdk.java.net/~jiefu/8233885/webrev.01/
> 
> Thanks a lot.
> Best regards,
> Jie
> 
> On 2019/11/11 上午11:56, Jie Fu wrote:
>> Hi all,
>>
>> May I get reviews for this small change?
>> This bug was found by running compiler/profiling/spectrapredefineclass/Launcher.java with -Xcomp.
>> The fix sets CompLevel_initial_compile to CompLevel_full_optimization if CompilationMode=high-only
>> is specified.
>>
>> JBS:    https://bugs.openjdk.java.net/browse/JDK-8233885
>> Webrev: http://cr.openjdk.java.net/~jiefu/8233885/webrev.00/
>>
>> Testing:
>>   - make test TEST="test/hotspot/jtreg/compiler" CONF=fastdebug on Linux/x64
>>
>> Thanks a lot.
>> Best regards,
>> Jie
>>
> 


More information about the hotspot-compiler-dev mailing list