RFR(XS): 8233918: 8233498 broke build on SPARC

erik.osterlund at oracle.com erik.osterlund at oracle.com
Mon Nov 11 16:54:57 UTC 2019


Hi Patric,

Looks good, and trivial. Ship it!

Thanks,
/Erik

On 11/11/19 5:49 PM, Patric Hedlin wrote:
> Dear all,
>
> I would like to ask for help to review the following change/update:
>
> Issue:  https://bugs.openjdk.java.net/browse/JDK-8233918
>
> 8233918: 8233498 broke build on SPARC
>
>     Pushed poor patch that broke debug builds.
>
>
> Testing: SPARC build on Solaris (sparcv9, sparcv9-debug, 
> sparcv9-slowdebug)
>
> Best regards,
> Patric
>
> -----8<-----
>
> diff -r e4d7fcab43d7 -r 0c993f1305eb 
> src/hotspot/cpu/sparc/interp_masm_sparc.hpp
> --- a/src/hotspot/cpu/sparc/interp_masm_sparc.hpp       Tue Apr 24 
> 13:59:02 2018 +0200
> +++ b/src/hotspot/cpu/sparc/interp_masm_sparc.hpp       Mon Nov 11 
> 16:59:42 2019 +0100
> @@ -321,6 +321,7 @@
>    // Debugging
>    void interp_verify_oop(Register reg, TosState state, const char * 
> file, int line);    // only if +VerifyOops && state == atos
>    void verify_oop_or_return_address(Register reg, Register rtmp); // 
> for astore
> +  void verify_FPU(int stack_depth, TosState state = ftos) {} // No-op.
>
>    // support for JVMTI/Dtrace
>    typedef enum { NotifyJVMTI, SkipNotifyJVMTI } NotifyMethodExitMode;
>



More information about the hotspot-compiler-dev mailing list