RFR: 8233885: Test fails with assert(comp != __null) failed: Ensure we have a compiler
Jie Fu
fujie at loongson.cn
Tue Nov 12 09:29:57 UTC 2019
Thanks Igor for your review.
Hope you can sponsor it.
Thanks a lot.
Best regards,
Jie
On 2019/11/12 下午5:11, Igor Veresov wrote:
> Looks good to me.
>
> igor
>
>
>
>> On Nov 12, 2019, at 12:36 AM, Tobias Hartmann
>> <tobias.hartmann at oracle.com <mailto:tobias.hartmann at oracle.com>> wrote:
>>
>> Hi Jie,
>>
>> seems reasonable to me but Igor should have a look as well.
>>
>> Thanks,
>> Tobias
>>
>> On 11.11.19 14:28, Jie Fu wrote:
>>> Hi Tobias,
>>>
>>> Thank you for your review and valuable comments.
>>> Updated: http://cr.openjdk.java.net/~jiefu/8233885/webrev.02/
>>>
>>> Thanks a lot.
>>> Best regards,
>>> Jie
>>>
>>> On 2019/11/11 下午3:44, Tobias Hartmann wrote:
>>>> Hi Jie,
>>>>
>>>> what about the high-only-quick-internal mode?
>>> It's really a nice catch.
>>> Fixed. Thanks.
>>>
>>>
>>>> While looking at the fix for 8227003, I spotted a little typo here
>>>> ("mininum"):
>>>> https://hg.openjdk.java.net/jdk/jdk/rev/b95bead30957#l6.8
>>>> Maybe you can fix that as well with your patch.
>>> Done.
>>>
>
More information about the hotspot-compiler-dev
mailing list