RFR: 8231954: [TESTBUG] Test compiler/codegen/TestCharVect2.java only works with server VMs.

Vladimir Kozlov vladimir.kozlov at oracle.com
Tue Nov 12 19:07:30 UTC 2019


I agree with this fix. Reviewed.

Thanks
Vladimir

> On Nov 12, 2019, at 4:07 AM, christoph.goettschkes at microdoc.com wrote:
> 
> Hi,
> 
> The test "compiler/codegen/TestCharVect2.java" uses the VM flag 
> "MaxVectorSize" which is not defined for all supported VM configurations. 
> Client VMs exit with an "Unrecognized VM option" error.
> 
> Bug: https://bugs.openjdk.java.net/browse/JDK-8231954
> Webrev: https://cr.openjdk.java.net/~bulasevich/8231954/webrev.00
> 
> Igor suggested to use the tag '@requires vm.flavor == "server"', but since 
> other tests like [1] and [2] are also using my suggested approach, and I 
> am uncertain how the flag MaxVectorSize plays together with the JVMCI, I 
> would currently stick with my approach and would like to get more feedback 
> on this topic. Also, the @requires tag would disable the test altogether, 
> but the first run (without the MaxVectorSize option) works in client VMs 
> and might be a viable test case, which is lost if the tag is added.
> 
> Thanks,
> Christoph
> 
> [1] 
> https://hg.openjdk.java.net/jdk/jdk/file/4dbdb7a8fa75/test/hotspot/jtreg/compiler/vectorization/TestNaNVector.java
> [2] 
> https://hg.openjdk.java.net/jdk/jdk/file/4dbdb7a8fa75/test/hotspot/jtreg/compiler/vectorization/TestPopCountVector.java
> 



More information about the hotspot-compiler-dev mailing list