RFR(T) : 8226795 : compiler/tiered/Level2RecompilationTest.java fails when XX:TieredStopAtLevel=1/2/3 is set

[Igor Ignatyev]

> On Nov 12, 2019, at 3:47 PM, Claes Redestad <claes.redestad at oracle.com> wrote:
> 
> Hi Igor,
> 
> fix looks good to me.
thanks.
> 
> A more open question: do tests that need to specifically compile with C2
> also need to be made aware of the recently added
> -XX:CompilationMode=quick-only flag? IIRC this would disable C2, but not
> in exactly the same way as TieredStopAtLevel=1/2/3 would
> (TieredStopAtLevel is ergonomically set to 4 in this case).
I think they do, I'll file an RFE to improve how we mark c2-only tests.

> 
> /Claes
> 
> On 2019-11-13 00:24, Igor Ignatyev wrote:
>> http://cr.openjdk.java.net/~iignatyev//8226795/webrev.00/index.html
>>> 13 lines changed: 12 ins; 0 del; 1 mod;
>> Hi all,
>> could you please review this small and trivial patch which adds @requires to exclude Level2RecompilationTest, OSRFailureLevel4Test, and TestTypeProfiling tests from execution w/ non default values of TieredStopAtLevel?
>> the tests expect to have tiered compilation enabled and level 4 compiler available, so they can't be run w/ TieredStopAtLevel < 4.
>> webrev: http://cr.openjdk.java.net/~iignatyev//8226795/webrev.00/index.html
>> JBS: https://bugs.openjdk.java.net/browse/JDK-8226795
>> testing: verified that changed tests are run w/o TieredStopAtLevel, w/ TieredStopAtLevel=4 and aren't run w/ TieredStopAtLevel != 4
>> Thanks,
>> -- Igor