RFR(S) : 8225756 : [testbug] compiler/loopstripmining/CheckLoopStripMining.java sets too short a SafepointTimeoutDelay

[Doerr, Martin]

Excellent. Thank you.
Martin


> -----Original Message-----
> From: Igor Ignatyev <igor.ignatyev at oracle.com>
> Sent: Mittwoch, 13. November 2019 20:31
> To: Doerr, Martin <martin.doerr at sap.com>; Ekaterina Pavlova
> <ekaterina.pavlova at oracle.com>; Vladimir Kozlov
> <vladimir.kozlov at oracle.com>; Roland Westrelin <rwestrel at redhat.com>
> Cc: hotspot compiler <hotspot-compiler-dev at openjdk.java.net>
> Subject: Re: RFR(S) : 8225756 : [testbug]
> compiler/loopstripmining/CheckLoopStripMining.java sets too short a
> SafepointTimeoutDelay
> 
> @Martin,
> I've updated the test according to your comments and also added 'to prevent
> biased locking handshakes from changing the timing' comment preceding '-
> XX:-UseBiasedLocking'.
> 
> @all, thanks for your review, pushed.
> 
> -- Igor
> 
> 
> > On Nov 13, 2019, at 3:37 AM, Doerr, Martin <martin.doerr at sap.com>
> wrote:
> >
> > Hi Igor,
> >
> > thanks for improving it.
> >
> > Please note that this test was derived from
> >
> test/hotspot/jtreg/runtime/Safepoint/TestAbortVMOnSafepointTimeout.ja
> va
> > JDK-8227528 has added -XX:-UseBiasedLocking.
> >
> > Would you mind adding that to your new version, too?
> >
> > Please also remove double-whitespace before Utils.adjustTimeout(500).
> >
> > Thanks and best regards,
> > Martin
> >
> >
> >> -----Original Message-----
> >> From: hotspot-compiler-dev <hotspot-compiler-dev-
> >> bounces at openjdk.java.net> On Behalf Of Roland Westrelin
> >> Sent: Mittwoch, 13. November 2019 10:20
> >> To: Igor Ignatyev <igor.ignatyev at oracle.com>; hotspot compiler
> <hotspot-
> >> compiler-dev at openjdk.java.net>
> >> Subject: Re: RFR(S) : 8225756 : [testbug]
> >> compiler/loopstripmining/CheckLoopStripMining.java sets too short a
> >> SafepointTimeoutDelay
> >>
> >>
> >> Looks reasonable to me.
> >>
> >> Thanks for fixing this, Igor.
> >>
> >> Roland.
> >