RFR: 8234499: [Graal] compiler/compilercontrol/CompilationModeHighOnlyTest.java test fails with timeout

Igor Ignatyev igor.ignatyev at oracle.com
Thu Nov 21 03:25:01 UTC 2019


Hi Jie,

just to double check, have you verified that the updated test can still provoke 8233885 ?

-- Igor 

> On Nov 20, 2019, at 6:48 PM, Jie Fu <fujie at loongson.cn> wrote:
> 
> Hi Igor,
> 
> OK.
> 
> Updated: http://cr.openjdk.java.net/~jiefu/8234499/webrev.02/
> 
> Thanks a lot.
> Best regards,
> Jie
> 
> On 2019/11/21 上午10:17, Igor Ignatyev wrote:
>> Hi Jie,
>> 
>> we are trying to replace all usages of -XX:CompileOnly w/ XX:CompileCommand=compileonly, could you please update your patch accordingly?
>> 
>> -- Igor
>> 
>>> On Nov 20, 2019, at 5:58 PM, Jie Fu <fujie at loongson.cn> wrote:
>>> 
>>> Hi Igor,
>>> 
>>> Good idea! Thank you very much.
>>> 
>>> Updated: http://cr.openjdk.java.net/~jiefu/8234499/webrev.01/
>>> 
>>> Hope you can sponsor it if you're OK with it.
>>> 
>>> Thanks a lot.
>>> Best regards,
>>> Jie
>>> 
>>> On 2019/11/21 上午9:05, Igor Ignatyev wrote:
>>>> Hi Jie,
>>>> 
>>>> wouldn't it be a better solution to limit compilation to CompilationModeHighOnlyTest via -XX:CompileControl=compileonly? this should solve timeout w/ Graal w/o removing the only test for CompilationMode=high-only?
>>>>  Thanks,
>>>> -- Igor
>>>> 
>>>>> On Nov 20, 2019, at 4:39 AM, Jie Fu <fujie at loongson.cn> wrote:
>>>>> 
>>>>> Hi all,
>>>>> 
>>>>> May I get reviews for this small fix?
>>>>> 
>>>>> JBS:    https://bugs.openjdk.java.net/browse/JDK-8234499
>>>>> Webrev: http://cr.openjdk.java.net/~jiefu/8234499/webrev.00/
>>>>> 
>>>>> And I need a sponsor.
>>>>> 
>>>>> Thanks a lot.
>>>>> Best regards,
>>>>> Jie
>>>>> 
> 



More information about the hotspot-compiler-dev mailing list