RFR: 8234321: Call cache flush after generating trampoline.

Xiaohong Gong (Arm Technology China) Xiaohong.Gong at arm.com
Thu Nov 21 06:24:02 UTC 2019


Hi Ioi,

Thanks for your reviewing!
And I'm glad that if you can help to push it if all the tests pass.

Thanks,
Xiaohong

-----Original Message-----
From: Ioi Lam <ioi.lam at oracle.com> 
Sent: Thursday, November 21, 2019 12:50 PM
To: Xiaohong Gong (Arm Technology China) <Xiaohong.Gong at arm.com>; Andrew Dinn <adinn at redhat.com>; hotspot-compiler-dev at openjdk.java.net; calvin.cheung at oracle.com
Cc: nd <nd at arm.com>
Subject: Re: RFR: 8234321: Call cache flush after generating trampoline.

Hi Xiaohong,

The changes look good to me. I am running tests on our test infrastructure now.

Do you need a sponsor for pushing the changeset?

Thanks
- Ioi

On 11/20/19 6:16 PM, Xiaohong Gong (Arm Technology China) wrote:
> Hi,
>
> Thanks for your reviewing! @Andrew Dinn So could someone else help to 
> review this patch? Thanks a lot if someone who are familiar with other platforms (ppc, etc) could take a look at it.
>
> Thanks,
> Xiaohong Gong
>
> -----Original Message-----
> From: Andrew Dinn <adinn at redhat.com>
> Sent: Wednesday, November 20, 2019 5:12 PM
> To: Xiaohong Gong (Arm Technology China) <Xiaohong.Gong at arm.com>; 
> hotspot-compiler-dev at openjdk.java.net; ioi.lam at oracle.com; 
> calvin.cheung at oracle.com
> Cc: nd <nd at arm.com>
> Subject: Re: RFR: 8234321: Call cache flush after generating trampoline.
>
> On 20/11/2019 06:36, Xiaohong Gong (Arm Technology China) wrote:
>> Please help to review this small patch:
>> Webrev: http://cr.openjdk.java.net/~xgong/rfr/8234321/webrev.00/
>> JBS: https://bugs.openjdk.java.net/browse/JDK-8234321
> Yes, the patch looks good.
>
> regards,
>
>
> Andrew Dinn
> -----------
> Senior Principal Software Engineer
> Red Hat UK Ltd
> Registered in England and Wales under Company Registration No. 
> 03798903
> Directors: Michael Cunningham, Michael ("Mike") O'Neill
>



More information about the hotspot-compiler-dev mailing list