[14] RFR(S): 8234583: PrintAssemblyOptions isn't passed to hsdis library

Vladimir Ivanov vladimir.x.ivanov at oracle.com
Mon Nov 25 16:05:26 UTC 2019


Lutz,

Can you elaborate, please, how the patch fixes the problem?

Why did you decide to add the following guards?

+  if ((options() == NULL) || (strlen(options()) == 0)) {

Best regards,
Vladimir Ivanov

On 25.11.2019 17:06, Schmidt, Lutz wrote:
> Dear all,
> 
> may I please request reviews for this small change, fixing a regression in the disassembler. Parameters to the hsdis-<platform> library were not passed on.
> 
> The change was verified to fix the issue by the reporter (Jean-Philippe Bempel, on CC:). jdk/submit tests pending...
> 
> Bug:    https://bugs.openjdk.java.net/browse/JDK-8234583
> Webrev: https://cr.openjdk.java.net/~lucy/webrevs/8234583.00/
> 
> Thank you,
> Lutz
> 


More information about the hotspot-compiler-dev mailing list