RFR(M): 8220376: C2: Int >0 not recognized as !=0 for div by 0 check

[Patric Hedlin]

Thanks for reviewing Martin.

Best regards,
Patric

On 18/11/2019 12:23, Doerr, Martin wrote:
> Hi Patric,
>
> I'd consider moving subsuming_bool_test_encode up to avoid the prototype.
> But I can also live with it.
>
> Looks good to me.
>
> Best regards,
> Martin
>
>
>> -----Original Message-----
>> From: Patric Hedlin <patric.hedlin at oracle.com>
>> Sent: Montag, 18. November 2019 11:06
>> To: hotspot-compiler-dev at openjdk.java.net; Nils Eliasson
>> <nils.eliasson at oracle.com>; Vladimir Ivanov
>> <vladimir.x.ivanov at oracle.com>; Doerr, Martin <martin.doerr at sap.com>
>> Subject: Re: RFR(M): 8220376: C2: Int >0 not recognized as !=0 for div by 0
>> check
>>
>> Dear all,
>>
>> Please review the new patch, now reduced to a "minimum" (besides the
>> table encoding).
>>
>> Updated in-place.
>> Webrev: http://cr.openjdk.java.net/~phedlin/tr8220376/
>>
>> Testing: hs-tier1-3
>>
>>
>> Best regards,
>> Patric
>>
>> On 12/11/2019 15:16, Patric Hedlin wrote:
>>> Dear all,
>>>
>>> I would like to ask for help to review the following change/update:
>>>
>>> Issue:  https://bugs.openjdk.java.net/browse/JDK-8220376
>>> Webrev: http://cr.openjdk.java.net/~phedlin/tr8220376/
>>>
>>> 8220376: C2: Int >0 not recognized as !=0 for div by 0 check
>>>
>>>      Adding a simple subsumption test to IfNode::Ideal to enable a local
>>>      short-circuit for (obviously) redundant if-nodes.
>>>
>>> Testing: hs-tier1-4, hs-precheckin-comp
>>>
>>>
>>> Best regards,
>>> Patric
>>>