RFR: 8234906: [TESTBUG] TestDivZeroCheckControl fails for client VMs due to Unrecognized VM option LoopUnrollLimit

[Vladimir Kozlov]

Hi Christoph

I was about suggest IgnoreUnrecognizedVMOptions flag but remembered discussion about 8231954 fix.
But I think the test should be run with Graal - it does have OSR compilation and we need to test it.

We can do it by splitting test runs (duplicate @test block with different run flags) to have 2 tests with different 
flags and conditions. See [1].

For existing @run block we use `@requires vm.compiler2.enabled` and for new without LoopUnrollLimit - `vm.graal.enabled`.

Thanks,
Vladimir

[1] test/hotspot/jtreg/runtime/exceptionMsgs/ArrayIndexOutOfBoundsException/ArrayIndexOutOfBoundsExceptionTest.java

On 11/27/19 4:55 AM, christoph.goettschkes at microdoc.com wrote:
> Hi,
> 
> please review the following small changeset which fixes the test
> test/hotspot/jtreg/compiler/loopopts/TestDivZeroCheckControl.java for
> client VMs.
> I added the requirement "vm.compiler2.enabled & !vm.graal.enabled", since
> the original bug is for C2 only. If I understand the bug description well,
> the provided test case works solely because of the provided
> "LoopUnrollLimit" flag, which is only valid for C2.
> 
> Bug: https://bugs.openjdk.java.net/browse/JDK-8234906
> Webrev: https://cr.openjdk.java.net/~cgo/8234906/webrev.00/
> 
> Bug which introduced the issue:
> https://bugs.openjdk.java.net/browse/JDK-8229496
> 
> Thanks,
> Christoph
>