[XXS] C1 misses to dump a reason when it inlines successfully

[Doerr, Martin]

Hi,

I agree with Tobias. " by the rules of C1" doesn't add any useful information IMHO.
But I'd be fine with just adding "inline" to avoid the confusion.

> Anyway, with your change, all callers now pass a msg argument and
> therefore the null handling logic
> should be removed (replaced by an assert). Also, the default value for the
> argument can be removed.
+1

Best regards,
Martin


> -----Original Message-----
> From: hotspot-compiler-dev <hotspot-compiler-dev-
> bounces at openjdk.java.net> On Behalf Of Tobias Hartmann
> Sent: Donnerstag, 28. November 2019 15:04
> To: Liu Xin <navy.xliu at gmail.com>; hotspot-compiler-dev at openjdk.java.net
> Subject: Re: [XXS] C1 misses to dump a reason when it inlines successfully
> 
> Hi,
> 
> I'm still not convinced that this message adds any useful information but let's
> see what other
> reviewers think.
> 
> Anyway, with your change, all callers now pass a msg argument and
> therefore the null handling logic
> should be removed (replaced by an assert). Also, the default value for the
> argument can be removed.
> 
> Best regards,
> Tobias
> 
> On 22.11.19 19:09, Liu Xin wrote:
> > hi, Reviewers,
> >
> > Could you review this extremely small change?
> > Bugs: https://bugs.openjdk.java.net/browse/JDK-8234541
> > Webrev: https://cr.openjdk.java.net/~xliu/8234541/00/webrev/
> >
> > When I analyzed PrintInlining, I was confused by the inline message
> without
> > any detail. It's not easy for developer to tell if this method is inlined
> > or not. This patch add a comment "inline by the rules of C1".
> >
> > I would like to add an explicit reason, but there's no decisive reason in
> > GraphBuilder::try_inline_full. It just passes all restrict rules. Any other
> > suggestion would be appreciated.
> >
> > Thanks,
> > --lx
> >