RFR: 8234894: [TESTBUG] TestEliminateLocksOffCrash fails for client VMs due to Unrecognized VM option EliminateLocks

Tobias Hartmann tobias.hartmann at oracle.com
Thu Nov 28 15:20:52 UTC 2019


Sure, pushed.

Best regards,
Tobias

On 28.11.19 16:17, christoph.goettschkes at microdoc.com wrote:
> Hi Tobias,
> 
> thanks for the review. I created the changeset:
> 
> https://cr.openjdk.java.net/~cgo/8234894/webrev.01/jdk-jdk.changeset
> 
> Could you please sponsor this change for me and commit it into the 
> repository?
> 
> Thanks,
> Christoph
> 
> Tobias Hartmann <tobias.hartmann at oracle.com> wrote on 2019-11-28 15:23:12:
> 
>> From: Tobias Hartmann <tobias.hartmann at oracle.com>
>> To: christoph.goettschkes at microdoc.com, 
> hotspot-compiler-dev at openjdk.java.net
>> Date: 2019-11-28 15:23
>> Subject: Re: RFR: 8234894: [TESTBUG] TestEliminateLocksOffCrash fails 
>> for client VMs due to Unrecognized VM option EliminateLocks
>>
>> Hi Christoph,
>>
>> looks good to me.
>>
>> Best regards,
>> Tobias
>>
>> On 27.11.19 10:57, christoph.goettschkes at microdoc.com wrote:
>>> Hi,
>>>
>>> please review the following small changeset which fixes the test 
>>>
> test/hotspot/jtreg/compiler/escapeAnalysis/TestEliminateLocksOffCrash.java 
> 
>>> for client VMs.
>>> I added the requirement "vm.compiler2.enabled & !vm.graal.enabled", 
> since 
>>> the original bug is for C2 only. Also, the flag EliminateLocks is only 
> 
>>> defined in c2_globals.hpp, and neither for C1, nor for JVMCI.
>>>
>>> Bug: https://bugs.openjdk.java.net/browse/JDK-8234894
>>> Webrev: https://cr.openjdk.java.net/~cgo/8234894/webrev.00
>>>
>>> Bug which introduced the issue:
>>> https://bugs.openjdk.java.net/browse/JDK-8227384
>>>
>>> Thanks,
>>> Christoph
>>>
>>
> 


More information about the hotspot-compiler-dev mailing list