RFR/RFC 8231503: [TESTBUG] compiler/{jvmci, aot} tests should not run with GCs that do not support JVMCI/AOT

Aleksey Shipilev shade at redhat.com
Tue Oct 1 15:16:25 UTC 2019


On 10/1/19 1:01 PM, Dmitry Samersoff wrote:
>> I don't think new flag wins us anything? I believe most of the tests
>> would then be:
>>  @requires vm.aot & vm.aot_compatible_gc
> 
> This combination gives to a Maintainer a clear point of what should be
> checked if the test doesn't run.

Already pushed, sorry.

But, in the same way, Maintainer would check the definition for vm.aot flag. It does not make sense
to me to always carry two flags for every test. I would think it is even greater headache for
maintenance to always remember @require-ing two flags.

-- 
Thanks,
-Aleksey


More information about the hotspot-compiler-dev mailing list