RFR: 8231659: [JVMCI] Could not work PrintAssembly for JVMCI installed code
Tom Rodriguez
tom.rodriguez at oracle.com
Mon Oct 7 22:13:11 UTC 2019
Nils Eliasson wrote on 10/7/19 5:05 AM:
> Hi,
>
> Related to the code you are changing:
>
> The CompilerDirectives is not supposed to be used in that way. The
> compiler should use the lookup to find a directive at the beginning of a
> compilation, and then keep using that directive for the entire duration
> of the compilation. Otherwise you may get different option values.
> PrintAssembly and PrintNMethod may not cause any failures or
> inconsistencies at the moment, but is still incorrect.
This path is not a normal CompileBroker compilation path so there are no
other uses of the CompilerDirectives to be inconsistent with. Is there
some other way this should be done?
tom
>
> Regards,
>
> Nils
>
>
> On 2019-10-01 10:57, Yasumasa Suenaga wrote:
>> Hi all,
>>
>> Please review this change.
>>
>> JBS: https://bugs.openjdk.java.net/browse/JDK-8231659
>> webrev: https://cr.openjdk.java.net/~ysuenaga/JDK-8231659/webrev.00/
>>
>> PrintAssembly would work in twice for JVMCI installed code before, so
>> I fixed it in JDK-8180601.
>> However PrintAseembly would not work for them in JDK 13 or later. It
>> seems due to JDK-8220623.
>>
>> JDK-8220623 lacks print_nmethod() call. Thus I revert JDK-8180601 to
>> work PrintAssembly.
More information about the hotspot-compiler-dev
mailing list