RFR(M) [14] : 8225654 : rework vmTestbase/jit/graph

[Igor Ignatyev]

@Nils,

I am not (and never was) afraid to bump up my reviews, it's just I myself forgot that I have this one pending, so it's on me ;)

anyhow, thanks for your review.

@list
can I get a second review?

Thanks,
-- Igor 

> On Oct 10, 2019, at 2:05 AM, Nils Eliasson <nils.eliasson at oracle.com> wrote:
> 
> Hi,
> 
> Sorry for missing your review request for so long. Don't be afraid to bump your review once in a while.
> 
> You have done a great job updating the test.
> 
> Reviewed,
> 
> Nils
> 
> 
> You have done
> 
> On 2019-10-10 03:24, Igor Ignatyev wrote:
>> anyone? the patch still applies cleanly to the current jdk/jdk. the testing has been re-run.
>> 
>> -- Igor
>> 
>>> On Jun 27, 2019, at 3:27 PM, Igor Ignatyev <igor.ignatyev at oracle.com> wrote:
>>> 
>>> ping?
>>> 
>>> -- Igor
>>> 
>>>> On Jun 19, 2019, at 5:32 PM, Igor Ignatyev <igor.ignatyev at oracle.com> wrote:
>>>> 
>>>> http://cr.openjdk.java.net/~iignatyev//8225654/webrev.00/index.html
>>>>> 2536 lines changed: 354 ins; 787 del; 1395 mod;
>>>> 
>>>> Hi all,
>>>> 
>>>> could you please review the patch which reworks vmTestbase/jit/graph to make them more readable and reliable?  that includes the following changes:
>>>> - as none of our cgt* tests used more than 1 thread, all test execution is now done in main thread;
>>>> - use exception instead of System::exit to signal problems;
>>>> - replaced ExecDriver execution mode w/ regular 'main';
>>>> - make the tests to use reproducible random from jdk.test.lib.Utils ;
>>>> - close filereader opened by jit/graph/Globals ;
>>>> - moved tests to one directory;
>>>> - mark a test as skipped if OOME or SOE happens
>>>> - editorial changes such as adding { }, fixing typos, removing commented code, etc.
>>>> 
>>>> webrev: http://cr.openjdk.java.net/~iignatyev//8225654/webrev.00/index.html
>>>> JBS: https://bugs.openjdk.java.net/browse/JDK-8225654
>>>> testing: test/hotspot/jtreg/vmTestbase/jit/graph on linux-x64,windows-x64,macosx-x64,solaris-sparcv9
>>>> 
>>>> Thanks,
>>>> -- Igor
>>>> 
>>>>