RFR(M) 8227003: [Graal] java/lang/invoke/VarHandles/VarHandleTestByteArrayAsInt.java time out
Igor Veresov
igor.veresov at oracle.com
Sun Oct 13 16:51:37 UTC 2019
Ok, I followed the notation you proposed, here’s the webrev: http://cr.openjdk.java.net/~iveresov/8227003/webrev.01/
igor
> On Oct 10, 2019, at 3:48 AM, Andrew Dinn <adinn at redhat.com> wrote:
>
> On 10/10/2019 10:39, Claes Redestad wrote:
>> How about:
>>
>> -XX:CompilationMode=<enum>
>>
>> enum := default|tiered|quickOnly|highOnly|highOnlyQuickInternal|...
>>
>> quickOnly => "TieredStopAtLevel=1"
>> highOnly => "-TieredCompilation for all"
>> highOnlyQuickInternal => -TieredCompilation with C1 for graal"
>>
>> I think this makes it clearer, and also easier to extend[1].
>
> Agreed.
>
>> I'm less enthused by the ability to manually pick threshold levels
>> - that we at all expose and thus lock us to what tier levels
>> exists feels like a mistake - and think we should move all such flag to
>> diagnostic, be wary of adding any more and take bigger liberties with
>> changing them as we see fit ergonomically.
>
> Also agreed.
>
>> $.02
> Krrching! $.04!
>
> regards,
>
>
> Andrew Dinn
> -----------
> Senior Principal Software Engineer
> Red Hat UK Ltd
> Registered in England and Wales under Company Registration No. 03798903
> Directors: Michael Cunningham, Michael ("Mike") O'Neill, Eric Shander
More information about the hotspot-compiler-dev
mailing list