RFR(M) 8227003: [Graal] java/lang/invoke/VarHandles/VarHandleTestByteArrayAsInt.java time out

Claes Redestad claes.redestad at oracle.com
Mon Oct 14 10:19:48 UTC 2019


On 2019-10-13 18:51, Igor Veresov wrote:
>   Ok, I followed the notation you proposed, here’s the webrev: 
> http://cr.openjdk.java.net/~iveresov/8227003/webrev.01/

Thanks for picking up the proposal! :-)

Some comments:

  - For the sake of completeness the default value should be explicit,
    i.e., tiered or default, and not NULL. Default flag values show up
    when running -XX:PrintFlagsFinal and such, so it's good with
    unsurprising output.

  - src/hotspot/share/runtime/globals.hpp:

    "TieredMode=4" in comments a number of times, should be something
    like "CompilationMode=highOnly|highOnlyQuickInternal"?

  - Since we're adding flags then I think a CSR is needed. My suggestion
    is to change subject to something like "Add high-level JIT
    compilation mode control mechanism".

Thanks!

/Claes


More information about the hotspot-compiler-dev mailing list