RFR(XS): 8232083: Minimal VM is broken after JDK-8231586

Jie Fu fujie at loongson.cn
Tue Oct 15 00:56:30 UTC 2019


Hi Tom,

Thanks for fixing this.

The patch seems to break the vm build:
---------------------------------------------
/home/fool/workspace/jdk-dev/src/hotspot/share/compiler/oopMap.cpp:343:3: 
error: expected unqualified-id before '{' token
    {
    ^
/home/fool/workspace/jdk-dev/src/hotspot/share/compiler/oopMap.cpp:394:1: 
error: expected declaration before '}' token
  }
  ^
lib/CompileJvm.gmk:176: recipe for target 
'/home/fool/workspace/jdk-dev/build/linux-x86_64-server-release/hotspot/variant-server/libjvm/objs/oopMap.o' 
failed
---------------------------------------------

Best regards,
Jie

On 2019/10/15 上午4:34, Tom Rodriguez wrote:
> Yes I mistranslated this code in the case where that ifndef triggers.  
> I think this http://cr.openjdk.java.net/~never/8232083/webrev/ is a 
> better translation of the original code.  Can I get a review of this 
> and I will push it.
>
> tom
>
> Jie Fu wrote on 10/13/19 11:35 PM:
>> Forward this to Tom. Thanks.
>>
>> On 2019/10/11 下午8:07, Jie Fu wrote:
>>> Hi all,
>>>
>>> JDK-8232151 had been fixed.
>>>
>>> Could you please review this fix and give me some advice?
>>>
>>> JBS:    https://bugs.openjdk.java.net/browse/JDK-8232083
>>> Webrev: http://cr.openjdk.java.net/~jiefu/8232083/webrev.00/
>>>
>>> Thanks a lot.
>>> Best regards,
>>> Jie
>>>
>>> On 2019/10/11 上午11:42, Jie Fu wrote:
>>>> Please hold off reviewing this until JDK-8232151 
>>>> <https://bugs.openjdk.java.net/browse/JDK-8232151> is fixed.
>>>
>>



More information about the hotspot-compiler-dev mailing list