RFR(XS): 8232083: Minimal VM is broken after JDK-8231586

[Tom Rodriguez]

Jie Fu wrote on 10/15/19 6:42 PM:
> Hi Tom,
> 
> It looks good to me. I'm NOT a reviewer.
> 
> How about the following change to the indentation?

Yes I've corrected that in place.  Can I get a review from a reviewer?

tom

> ------------------------------------------
> diff -r a3b0294dfbb5 src/hotspot/share/compiler/oopMap.cpp
> --- a/src/hotspot/share/compiler/oopMap.cpp     Wed Oct 16 09:27:33 2019 
> +0800
> +++ b/src/hotspot/share/compiler/oopMap.cpp     Wed Oct 16 09:32:48 2019 
> +0800
> @@ -313,14 +313,14 @@
>         OopMapValue omv = oms.current();
>         if (omv.type() != OopMapValue::derived_oop_value) {
>           continue;
> -        }
> +      }
> 
>   #ifndef TIERED
>         COMPILER1_PRESENT(ShouldNotReachHere();)
>   #if INCLUDE_JVMCI
> -        if (UseJVMCICompiler) {
> -          ShouldNotReachHere();
> -        }
> +      if (UseJVMCICompiler) {
> +        ShouldNotReachHere();
> +      }
>   #endif
>   #endif // !TIERED
>         oop* loc = fr->oopmapreg_to_location(omv.reg(),reg_map);
> ------------------------------------------
> 
> Thanks a lot.
> Best regards,
> Jie
> 
> On 2019/10/16 上午12:58, Tom Rodriguez wrote:
>> I've corrected the code at 
>> http://cr.openjdk.java.net/~never/8232083.1/webrev and built and ran 
>> both a normal and minimal JVM using these changes.
>