RFR(trivial): 8232692: [TESTBUG] compiler/aot/fingerprint/SelfChangedCDS.java fails when cds is disabled
Jie Fu
fujie at loongson.cn
Tue Oct 22 02:06:51 UTC 2019
Thank you so much, Vladimir.
On 2019/10/22 上午10:04, Vladimir Kozlov wrote:
> Sorry, I missed that you need sponsor.
>
> I pushed changes.
>
> Regards,
> Vladimir
>
> On 10/21/19 7:02 PM, Vladimir Kozlov wrote:
>> Yes, it is trivial
>>
>> Vladimir
>>
>> On 10/21/19 6:13 PM, Jie Fu wrote:
>>> Hi Vladimir,
>>>
>>> Thanks for your review.
>>>
>>> Updated: http://cr.openjdk.java.net/~jiefu/8232692/webrev.01/
>>> - just added the reviewer in it.
>>>
>>> Is it OK to be pushed? I think it's trivial.
>>> And I need a sponsor.
>>>
>>> Thanks a lot.
>>> Best regards,
>>> Jie
>>>
>>> On 2019/10/22 上午2:09, Vladimir Kozlov wrote:
>>>> Right! Thank you for fixing it.
>>>>
>>>> Vladimir
>>>>
>>>> On 10/21/19 2:32 AM, Jie Fu wrote:
>>>>> Hi all,
>>>>>
>>>>> May I get reviews for this one-line fix?
>>>>>
>>>>> JBS: https://bugs.openjdk.java.net/browse/JDK-8232692
>>>>> Webrev: http://cr.openjdk.java.net/~jiefu/8232692/webrev.00/
>>>>>
>>>>> This bug was found after JDK-8232616 had been fixed.
>>>>> When cds is disabled, all tests under compiler/aot passed except
>>>>> this one.
>>>>> So it might be better to fix it.
>>>>>
>>>>> Thanks a lot.
>>>>> Best regards,
>>>>> Jie
>>>>>
>>>>>
>>>
More information about the hotspot-compiler-dev
mailing list