[aarch64-port-dev ] RFR(S): 8232591: AArch64: Add missing match rules for smaddl, smsubl and smnegl
Pengfei Li (Arm Technology China)
Pengfei.Li at arm.com
Mon Oct 28 09:48:31 UTC 2019
Hi,
> > Yes, I think so. It's enough to make sure that the corner cases and
> > overflows are handled correctly. We have to be sure that we really are
> > generating the correct instructions. Thanks.
>
> By the way, I also checked with this Case:
>
> new Case(0xffffffff, 0xffffffff, 0xffffffffeL << 32, 0xfffffffe00000001L,
> 0xfffffffdffffffffL, -1L),
>
> which tests the carries frm highpart to lowpart.
> (It's the result of 0xffffffff * 0xffffffff == 0xfffffffe00000001.)
Thanks for review. I've appended this case in my jtreg.
See updated webrev: http://cr.openjdk.java.net/~pli/rfr/8232591/webrev.02/
Is another reviewer required for this change? If not, @Ningsheng Jian (Arm Technology China) could you help to push?
--
Thanks,
Pengfei
More information about the hotspot-compiler-dev
mailing list