8226721: Missing intrinsics for Math.ceil, floor, rint

Eric Caspole eric.caspole at oracle.com
Tue Sep 3 19:37:15 UTC 2019


Hi Jatin,
I have a few comments on the JMH in the webrev:

1 - Make the TESTSIZE into a JMH Param, so it will be more versatile:

   public final int TESTSIZE = 1024;

becomes:

   @Param({"1024"})
   public int testSize;


2 - the DspecialVals is not used at all

   public final double[] DspecialVals = {
       0.0, -0.0, Double.NaN, Double.NEGATIVE_INFINITY, 
Double.POSITIVE_INFINITY};



Thanks for including the JMH from start with your webrev.
Eric


On 9/3/19 05:41, Bhateja, Jatin wrote:
> Hi All,
> 
> Please find a patch with the following changes:-
> 1) Intrincifiation for Math.ceil/floor/rint.
> 2) Auto-vectorizer handling.
> 
> JBS: https://bugs.openjdk.java.net/browse/JDK-8226721
> Webrev: http://cr.openjdk.java.net/~jbhateja/8226721/webrev.05
> 
> Kindly review it.
> 
> Best Regards,
> Jatin
> 


More information about the hotspot-compiler-dev mailing list