RFR(XS): 8230434: [C1, C2] Release barrier for volatile field stores in constructors implemented inconsistently

Doerr, Martin martin.doerr at sap.com
Wed Sep 4 12:24:17 UTC 2019


Hi Aleksey and Lutz,

thank you for reviewing. Pushed.

Best regards,
Martin


> -----Original Message-----
> From: Schmidt, Lutz
> Sent: Mittwoch, 4. September 2019 12:08
> To: Aleksey Shipilev <shade at redhat.com>; Doerr, Martin
> <martin.doerr at sap.com>; 'hotspot-compiler-dev at openjdk.java.net'
> <hotspot-compiler-dev at openjdk.java.net>
> Subject: Re: RFR(XS): 8230434: [C1, C2] Release barrier for volatile field stores
> in constructors implemented inconsistently
> 
> Hi Martin,
> the changes look good to me. I like the cleanup and the "synchronization" of
> coding style.
> Please note that I'm NOT a Reviewer.
> Thanks,
> Lutz
> 
> On 03.09.19, 15:59, "hotspot-compiler-dev on behalf of Aleksey Shipilev"
> <hotspot-compiler-dev-bounces at openjdk.java.net on behalf of
> shade at redhat.com> wrote:
> 
>     On 9/3/19 3:37 PM, Doerr, Martin wrote:
>     > Sure, I can also clean up coding style:
>     >
> http://cr.openjdk.java.net/~mdoerr/8230434_membar_volatile_field_constr
> uctor/webrev.01/
>     This looks good to me.
> 
>     --
>     Thanks,
>     -Aleksey
> 
> 



More information about the hotspot-compiler-dev mailing list