RFR(XXS) 8230363: C2: Let ConnectionGraph::not_global_escape(Node* n) return false if n is not in the CG

[Reingruber, Richard]

Thanks for the review Martin. I'll push now to the submit repo.

Cheers, Richard.

-----Original Message-----
From: Doerr, Martin <martin.doerr at sap.com> 
Sent: Mittwoch, 4. September 2019 16:03
To: Reingruber, Richard <richard.reingruber at sap.com>; Tobias Hartmann <tobias.hartmann at oracle.com>; hotspot-compiler-dev at openjdk.java.net
Subject: RE: RFR(XXS) 8230363: C2: Let ConnectionGraph::not_global_escape(Node* n) return false if n is not in the CG

Hi Richard,

the updated webrev looks good to me.
Returning false makes sense. The function is designed to only return true if it can prove "not global escape".

Best regards,
Martin


> -----Original Message-----
> From: hotspot-compiler-dev <hotspot-compiler-dev-
> bounces at openjdk.java.net> On Behalf Of Reingruber, Richard
> Sent: Freitag, 30. August 2019 09:44
> To: Tobias Hartmann <tobias.hartmann at oracle.com>; hotspot-compiler-
> dev at openjdk.java.net
> Subject: RE: RFR(XXS) 8230363: C2: Let
> ConnectionGraph::not_global_escape(Node* n) return false if n is not in the
> CG
> 
> Hi Tobias,
> 
> your right, that's better. I've updated the webrev in place.
> 
> Thanks for your review!
> Richard.
> 
> -----Original Message-----
> From: Tobias Hartmann <tobias.hartmann at oracle.com>
> Sent: Freitag, 30. August 2019 08:52
> To: Reingruber, Richard <richard.reingruber at sap.com>; hotspot-compiler-
> dev at openjdk.java.net
> Subject: Re: RFR(XXS) 8230363: C2: Let
> ConnectionGraph::not_global_escape(Node* n) return false if n is not in the
> CG
> 
> Hi Richard,
> 
> looks good to me but please check ptn == NULL instead of casting to boolean
> before pushing.
> 
> Thanks,
> Tobias
> 
> On 29.08.19 22:31, Reingruber, Richard wrote:
> > Hi,
> >
> > could I please get reviews and sponsoring for
> >
> > Webrev:
> http://cr.openjdk.java.net/~rrich/webrevs/2019/8230363/webrev.0/
> > Bug:    https://bugs.openjdk.java.net/browse/JDK-8230363
> >
> > The fix avoids crashes if ConnectionGraph::not_global_escape(Node* n)
> should be called with a node n
> > that was not added to the connection graph. Note that not all ideal nodes
> are added (e.g. constant
> > numbers). This case should be handled more gracefully by returning false.
> >
> > This is split off from JDK-8227745[1]. There not_global_escape() is applied
> to the arguments of java
> > calls. If one argument should be e.g. an integer constant
> not_global_escape() would crash.
> >
> > I've run tier1 tests.
> >
> > Thanks, Richard.
> >
> > [1] https://bugs.openjdk.java.net/browse/JDK-8227745
> >